[
https://issues.apache.org/jira/browse/AIRFLOW-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847940#comment-16847940
]
ASF subversion and git services commented on AIRFLOW-4295:
----------------------------------------------------------
Commit b4e610a29e97858ebc8073b870d9cee916b428c5 in airflow's branch
refs/heads/v1-10-test from Karl Andersson
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=b4e610a ]
[AIRFLOW-4295] Make `method` attribute case insensitive in HttpHook (#5313)
Make the method: `run` in the HttpHook compare the attribute: 'method' in a
case insensitive way.
This resolves the issue where a Httphook created with parameter `method='get'`
would not be
treated as a GET-request in the run method and the attribute `params`would be
omitted in the Http request.
(cherry picked from commit 88564d546cbb2a708b055ff98d85ab6355298292)
> HttpHook allows to create methods in lower case, e.g 'get' but correct usage
> requires method to be in upper case
> ----------------------------------------------------------------------------------------------------------------
>
> Key: AIRFLOW-4295
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4295
> Project: Apache Airflow
> Issue Type: Bug
> Components: hooks
> Affects Versions: 1.10.2
> Reporter: Karl Andersson
> Assignee: Karl Andersson
> Priority: Minor
> Fix For: 1.10.4
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The HttpHook except any value for variable `method` in the constructor.
> However, creating a hook with method = 'get' will cause the run-function not
> to treat it as a GET reqest and the `params` parameter will not be used. This
> is confusing as the request will just omit the `params` parameter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
