malthe commented on a change in pull request #20731:
URL: https://github.com/apache/airflow/pull/20731#discussion_r807044544
##########
File path: airflow/models/taskinstance.py
##########
@@ -1737,7 +1758,15 @@ def handle_failure(
if error:
if isinstance(error, BaseException):
- self.log.error("Task failed with exception", exc_info=error)
+ execution_frame = _EXECUTION_FRAME_MAPPING.get(self.task)
Review comment:
@ashb yes sometimes it is not in the dictionary, there are various ways
a task can fail and only some of them will produce a traceback during execution.
##########
File path: airflow/models/taskinstance.py
##########
@@ -1737,7 +1758,15 @@ def handle_failure(
if error:
if isinstance(error, BaseException):
- self.log.error("Task failed with exception", exc_info=error)
+ execution_frame = _EXECUTION_FRAME_MAPPING.get(self.task)
Review comment:
But yeah the `None` part is not needed – `get` should be fine if the
task is not there with `None` being returned in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
