potiuk edited a comment on pull request #21294: URL: https://github.com/apache/airflow/pull/21294#issuecomment-1041271946
> @aa3pankaj, can you fix the conflict in `setup.cfg`? Also can you add a comment explaining why we are pinning FAB? > > @potiuk, do you think we should accept a range here, with a strict upper bound instead? e.g from the current `flask-appbuilder~=3.4, <4.0.0` to `flask-appbuilder~=3.4, <=3.4.4` instead of pinning to only `3.4.4`. I think because of the way we vendor parts of FAB's code, we should basically every time manually review if there are any changes coming in the new FAB version (we already got examples of that in patchlevel and actually it is not FAB's fault - it's our approach to vendor in parts of the code). Ths is one of the "justified exceptions" from no-upper bounding IMHO. And I think in this case we are pretty much tightly-coupled with the version of FAB. I think ==3.4.4 is fine. And we should have have comment explaining it. "Every time you bump version of FAB here, make sure that you review this and that file and compare it with this and that files in FAB to see if they need syncronizing". This will keep us in perfect sync with FAB code (until we remove it as dependency) and our users will avoid surprises. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
