dstandish commented on a change in pull request #19505:
URL: https://github.com/apache/airflow/pull/19505#discussion_r808115736
##########
File path: airflow/models/xcom.py
##########
@@ -458,8 +469,8 @@ def clear(
return query.delete()
@staticmethod
- def serialize_value(value: Any):
- """Serialize Xcom value to str or pickled object"""
+ def serialize_value(value: Any, key=None, task_id=None, dag_id=None,
execution_date=None, run_id=None):
Review comment:
ha, yes of course. i was thinking in comparison with
[here](https://github.com/apache/airflow/blob/ddb5246bd1576e2ce6abf8c80c3328d7d71a75ce/airflow/models/xcom.py#L101)
but upon closer inspection that's just an overload method and not the actual
signature. and i also had in mind the question of signature change -- making
`value` kwarg only where previously it was not. but i guess since we're
changing signature anyway it may not matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
