ashb commented on a change in pull request #21301:
URL: https://github.com/apache/airflow/pull/21301#discussion_r809227751
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -1120,11 +1125,9 @@ def _verify_integrity_if_dag_changed(self, dag_run:
DagRun, session=None):
dag_run.verify_integrity(session=session)
def _send_dag_callbacks_to_processor(self, dag: DAG, callback:
Optional[DagCallbackRequest] = None):
- if not self.processor_agent:
- raise ValueError("Processor agent is not started.")
self._send_sla_callbacks_to_processor(dag)
if callback:
- self.processor_agent.send_callback_to_execute(callback)
+ self.executor.send_callback_to_execute(callback)
Review comment:
The `to_execute` suffix here doesn't make as much sense now it's on the
executor -- it's implied.
So I would say we should change this to one of/something like
```suggestion
self.executor.queue_callback(callback)
self.executor.send_callback(callback)
self.executor.execute_callback(callback)
```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
