uranusjr commented on pull request #21688: URL: https://github.com/apache/airflow/pull/21688#issuecomment-1046326977
If the two functions are indeed equivalent, perhaps we should deprecate `check_cycle` altogether. Also if we are to replace `check_cycle` with `topological_sort` (whether to deprecate the former or not), the latter needs to be modified to raise `AirflowDagCycleException` instead, for backward compatibility. (Fortunately it currently raise `AirflowException`, which is the superclass of `AirflowDagCycleException`, so changing the exception type would be backward compatible.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
