uranusjr commented on a change in pull request #21670:
URL: https://github.com/apache/airflow/pull/21670#discussion_r810841511
##########
File path:
airflow/migrations/versions/30867afad44a_rename_concurrency_column_in_dag_table_.py
##########
@@ -36,13 +36,20 @@
def upgrade():
"""Apply Rename concurrency column in dag table to max_active_tasks"""
+ conn = op.get_bind()
+ is_sqlite = bool(conn.dialect.name == "sqlite")
Review comment:
BTW this `conn.dialect.name` check appears much too often in our
migrations files (not just those modified in this PR but generally) maybe we
should extract the logic to somewhere like `airflow.utils.db`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
