utkarsharma2 commented on a change in pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#discussion_r810846748
##########
File path: airflow/providers/presto/hooks/presto.py
##########
@@ -112,8 +112,20 @@ def get_isolation_level(self) -> Any:
def _strip_sql(sql: str) -> str:
return sql.strip().rstrip(';')
+ @overload
+ def get_records(self, sql: str = "", parameters: Optional[dict] = None):
+ """Get a set of records from Presto
+ :param sql: SQL statement to be executed.
+ :param parameters: The parameters to render the SQL query with.
+ """
+ ...
+
+ @overload
def get_records(self, sql: str = "", parameters: Optional[dict] = None,
hql: str = ""):
- """Get a set of records from Presto"""
+ ...
Review comment:
Static checks were failing on local(MyPy) - Single overload definition,
multiple required.
And the workaround I found was to have two different signatures in two
@overload signatures. And the actual function header for the implementation
should be empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
