wanlce opened a new pull request #21715:
URL: https://github.com/apache/airflow/pull/21715


   This PR fixes the incorrect first run of data_interval_start after
   changing the scheduling time.
   
   New version of the timetables issue
   
   eg:
   At first I had a scheduling time of 30 * * * * *
   After running it twice, I changed it to 32 * * * *
   The actual first run time after the change is fine, but because the data 
interval starts from the end of the previous interval, it has already been 
determined and not refreshed, so the displayed execution_date is incorrect.   
This can cause problems with Cross-dag dependencies.
   
   
![2022-02-15_23-34](https://user-images.githubusercontent.com/55907021/154095279-27cf10cf-04d2-4849-a1a5-0ecbab92e19e.png)
  |  
![2022-02-15_23-36](https://user-images.githubusercontent.com/55907021/154095460-fea4fe68-8bbb-45ff-96c7-ec28c42cbfbe.png)
   --- | ---
   
   Correct:
   
![2022-02-15_23-26](https://user-images.githubusercontent.com/55907021/154099117-78bb4fe1-9c14-4073-905f-3dc6493ef27f.png)
  | 
![2022-02-15_23-27](https://user-images.githubusercontent.com/55907021/154099134-697d9ad3-6f4d-48b9-af51-fd93f8a18df9.png)
   --- | ---
   
   My current solution is to add `start = self._get_prev(end)` below `end = 
self._get_next(start)` to reset data_interval_start.
   I'm not sure if this is appropriate :smiley:
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to