Eronarn commented on issue #4277: [AIRFLOW-3217] Airflow log view and code view 
should wrap
URL: https://github.com/apache/airflow/pull/4277#issuecomment-496562584
 
 
   @kaxil I changed the default setting to not wrap. I also tested this for the 
code view, and the button does work. I wasn't able to test with the log view, 
as I couldn't get a functioning worker environment to generate logs.
   
   One complication here with the code view is that the line number code 
creates a 2x1 table: all the line numbers are in one cell, and all the code is 
in another cell. This means that there is no way to actually wrap the line 
numbers correctly to the line they represent. Fixing that would require 
tweaking how we generate the HTML from pygments, to create one table row per 
line of code. But that's getting into a larger PR, and I'd rather just drop 
code view wrapping from this PR rather than implementing that right now...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to