hsrocks commented on pull request #21073: URL: https://github.com/apache/airflow/pull/21073#issuecomment-1052315802
I went through the code to analyse the changes and need input. The secret class uses profile_name also as an optional to load credentials. but SSMParameterStoreHook uses AWSBaseHook which don't accept profile_name as an argument or part of any config(please feel free to correct me if I am mistaken but I cant find it as part of AWSBaseHook class) Because it uses aws_conn_id param which can get connection from profile, aws credential etc (https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/connections/aws.html) . So how the config will be loaded for SystemsManagerParameterStoreBackend if we switch to SSMParameterStoreHook ? Will it be with aws_conn_id? Then will it impact loaded of configurations and connection object ? Also, I am not completely sure on this, but how the secrets are loaded vs Hooks are loaded /evaluated will there be any impact in sense of variable loading when we switch secret classes to use Hook? Please help me with above information . Thanks! CC: @potiuk @o-nikolas @dbarrundiag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
