nvtkaszpir commented on a change in pull request #4703: [AIRFLOW-3885] Improve Travis CI cycle time URL: https://github.com/apache/airflow/pull/4703#discussion_r288216436
########## File path: scripts/ci/6-check-license.sh ########## @@ -17,13 +16,29 @@ # limitations under the License. # +declare -r RAT_VERSION=0.12 +declare -r URL="http://repo1.maven.org/maven2/org/apache/rat/apache-rat/${RAT_VERSION}/apache-rat-${RAT_VERSION}.jar"; -acquire_rat_jar () { +declare -r TMP_DIR=/tmp +declare -r rat_jar="${TMP_DIR}"/lib/apache-rat-${RAT_VERSION}.jar Review comment: Yes, I'm aware it works, but looking at the fact that there is furhter on `${RAT_VERSION}` I would rather expect the whole `declare -r rat_jar=` to be double quoted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
