mhenc commented on a change in pull request #21731:
URL: https://github.com/apache/airflow/pull/21731#discussion_r817106960
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -858,7 +865,7 @@ def _do_scheduling(self, session) -> int:
self.log.error("DAG '%s' not found in serialized_dag
table", dag_run.dag_id)
continue
- self._send_dag_callbacks_to_processor(dag, callback_to_run)
+ callbacks_to_send.append((dag, callback_to_run))
Review comment:
Alternatively we could end the previous guard just before, send
callbacks to DB then start another guard below.
I don't know how important it is to keep the single guard for all these
lines 843-900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
