ephraimbuddy commented on pull request #21829:
URL: https://github.com/apache/airflow/pull/21829#issuecomment-1057717954


   > I'm just concerned that making this an import error will negatively impact 
developer experience, and I'm trying to help think about alternatives that 
achieve similar goals. Because I think locally it's common you won't have all 
the pools, so it feels ilke it should be a warning of some kind but not a hard 
error (and if you just do a warning, presumably the concerns in the scheduler 
can be addressed by modifying queries to filter out TIs with bad pools).
   
   
   I understand and I'm not arguing about it.
   
   > But I think (1) being able to disable consideration (in the scheduler) of 
pools would make this work. And another thing that I think would work, and 
which would be really nice in general, would be (2) to make it so you didn't 
need to create the pools in the db e.g. if they could be defined in airflow.cfg 
or if you could do AIRFLOW_POOL_MY_POOL=1. With either or both of these in 
place, I think raising would be ok. It's easier to manage for local developers 
than having to add the pools to the db, and it would not be affected negatively 
by resetting the db.
   
   
   I'll spend some time on it today to make a different PRs based on the 
suggestions
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to