TreyYi edited a comment on issue #21982:
URL: https://github.com/apache/airflow/issues/21982#issuecomment-1058885476
@potiuk @rustikk ,
Can I be assigned for this issue? I know what the problem is, but still
thinking of how to resolve it.
The problem is that the log is printed whenever "are_dependencies_met" is
called.
In `taskinstance.py`, are_dependencies_met is called even if the
`verbose_aware_logger("Dependencies all met for %s", self)` line doesn't need
to be always necessary.
I think `non_requeueable_dep_context` should be called, but
`verbose_aware_logger("Dependencies all met for %s", self)` should be called
only once in `__init__`.
```
# taskinstance.py
# line 1202~
if not self.are_dependencies_met(
dep_context=non_requeueable_dep_context, session=session,
verbose=True
):
session.commit()
return False
```
```
# taskinstance.py
# line 1230~
if not self.are_dependencies_met(dep_context=dep_context, session=session,
verbose=True):
self.state = State.NONE
self.log.warning(hr_line_break)
self.log.warning(
"Rescheduling due to concurrency limits reached "
"at task runtime. Attempt %s of "
"%s. State set to NONE.",
self.try_number,
self.max_tries + 1,
)
self.log.warning(hr_line_break)
self.queued_dttm = timezone.utcnow()
session.merge(self)
session.commit()
return False
```
```
# taskinstance.py
# line 1050~
...
verbose_aware_logger("Dependencies all met for %s", self)
```
In terms of PR, I would love to hear any suggestions from you. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
