josh-fell commented on pull request #21997: URL: https://github.com/apache/airflow/pull/21997#issuecomment-1059615713
It would be a good idea to add a `test_connection_failed` test as well. Also, it doesn't need to be in this PR but feel free to add if you feel up to it, to also add tests for `test_connection()` for the `FTPSHook` too especially since it inherits from `FTPHook` and overwrites `get_conn()` (which is used in `FTPHook.test_connection()`). WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
