potiuk commented on pull request #22017: URL: https://github.com/apache/airflow/pull/22017#issuecomment-1060034762
> @potiuk isn't it possible (and easier) to skip these tests "from the outside" – ? > > I would think `skipif` is more suitable for a situation where you want to skip a test depending on for example the operating system. How would you imagine "externall" exclusion :)? I would like to avoid having anyone to add extra pytest arguments or command line switches to skip those. The idea is that whoever runs "All tests" for Airlflow can see them succeed, no matter if they specify some exclusions. In our case, if you want to make sure that all tests are succeeding you do this: * `./breeze build-image --python 3.7` * `./breeze --backend mysql` * while in "breeze" you run `pytest tests` Those three commands should lead to successful test execution. Having to add some additional exclusion rules is bad, especially in case we want Dask team members to help with fixing those. What we ask them, is to make either remove skipIf (initially set the `skip_dask_test' to False and run the failed tests. They do not have to learn anything about external scripts and "Exclusions" we do outside of our "python" code. their fix will be limited to "dask" tests only - they don't have to understand what our CI does and how we exclude stuff externally. I think in this case skip if "close" to the tests being disabled is exactly what we need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
