subkanthi commented on a change in pull request #22027:
URL: https://github.com/apache/airflow/pull/22027#discussion_r820337396
##########
File path: tests/executors/test_dask_executor.py
##########
@@ -121,27 +120,27 @@ def setUp(self):
@conf_vars(
{
- ('dask', 'tls_ca'): get_cert('tls-ca-cert.pem'),
- ('dask', 'tls_cert'): get_cert('tls-key-cert.pem'),
- ('dask', 'tls_key'): get_cert('tls-key.pem'),
+ ('dask', 'tls_ca'): 'certs/tls-ca-cert.pem',
+ ('dask', 'tls_cert'): 'certs/tls-key-cert.pem',
+ ('dask', 'tls_key'): 'certs/tls-key.pem',
}
)
- def test_tls(self):
- # These use test certs that ship with dask/distributed and should not
be
- # used in production
- with dask_testing_cluster(
- worker_kwargs={'security': tls_security(), "protocol": "tls"},
Review comment:
Atleast on my local, most of the tests were failing because of errors
with pickling the function, the change in [airflow/executors/dask_executor.py],
fixed it
- future = self.client.submit(airflow_run, pure=False,
resources=resources)
+ future = self.client.submit(subprocess.check_call, command,
pure=False, resources=resources)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
