EricGao888 commented on pull request #21954: URL: https://github.com/apache/airflow/pull/21954#issuecomment-1060402504
> > @potiuk Hello, as the initial PR to add a new provider to airflow, this PR contains many new files. Should I add all the unit tests in order to merge this PR? If so, would it be better to separate this work into several sub PRs since there will be twice amount of new files once the unit tests are added. It will be difficult for reviewers to review such a pr. Any suggestions will be appreciated! : ) > > Yes. Uniit tests shoudl be added together with the main code. Also documentation and howtos and example dags ideally. What you can do to split it into smaller PRs is to first add Hooks separately (with unit tests) amd some basic documentation and then add operators as a separate PR. But our approach is that we prefer to have "everything" that relates to the same functionality (code, unit tests, docs) in one PR. Thanks for the explanations 👍 I will submit a pr for hooks with unit tests and docs first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
