ashb commented on a change in pull request #5343: Tasks default to use default_pool URL: https://github.com/apache/airflow/pull/5343#discussion_r288918215
########## File path: airflow/config_templates/default_airflow.cfg ########## @@ -132,14 +132,6 @@ dag_concurrency = 16 # Are DAGs paused by default at creation dags_are_paused_at_creation = True -# When not using pools, tasks are run in the "default pool", -# whose size is guided by this config element -non_pooled_task_slot_count = 128 Review comment: This overall feels like it makes the code cleaner, but I do wonder if it's useful to keep this config setting (so that people can tweak the behaviour of the Airflow without _having_ to go in to the UI and change behaviours. (i.e. we could set the default_pool slots to the config value on bootup?) Not sure. If we do decide to delete these two config values we should add a note to UPDATING.md about it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
