hsrocks commented on a change in pull request #21863: URL: https://github.com/apache/airflow/pull/21863#discussion_r821714920
########## File path: airflow/providers/amazon/aws/hooks/quicksight.py ########## @@ -0,0 +1,143 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import time +from typing import Optional + +from botocore.exceptions import ClientError + +from airflow import AirflowException +from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook + + +class QuickSightHook(AwsBaseHook): + """ + Interact with Amazon QuickSight. + + Additional arguments (such as ``aws_conn_id``) may be specified and + are passed down to the underlying AwsBaseHook. + .. seealso:: + :class:`~airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook` + """ + + NON_TERMINAL_STATES = {"INITIALIZED", "QUEUED", "RUNNING"} + FAILED_STATES = {"FAILED"} + + def __init__(self, *args, **kwargs): + super().__init__(client_type="quicksight", *args, **kwargs) Review comment: > Why do you need to specify `client_type` here? I was initialising the boto3.client as quicksight . Please let me know if I am doing it wrong way . As per basehook : https://airflow.apache.org/docs/apache-airflow-providers-amazon/1.0.0/_modules/airflow/providers/amazon/aws/hooks/base_aws.html :param client_type: boto3.client client_type. Eg 's3', 'emr' etc So for quicksight I put it like this . Is there better way or suggested approach for this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
