jedcunningham commented on a change in pull request #22100:
URL: https://github.com/apache/airflow/pull/22100#discussion_r822087985
##########
File path: setup.py
##########
@@ -275,7 +275,7 @@ def write_version(filename: str = os.path.join(*[my_dir,
"airflow", "git_version
'sphinx-argparse>=0.1.13',
'sphinx-autoapi>=1.8.0',
'sphinx-copybutton',
- 'sphinx-jinja>=1.1',
+ 'sphinx-jinja>=1.1, <2.0',
Review comment:
```suggestion
# we can remove the upper limit when we apply the fix as explained in
the change log:
#
https://github.com/tardyp/sphinx-jinja/blob/d4f3ba9aa2b6a1217dfd90c676475d516e69b306/ChangeLog#L8-L16
'sphinx-jinja>=1.1, <2.0',
```
nit: I think we should comment why we have an upper bound
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
