ephraimbuddy commented on a change in pull request #19758:
URL: https://github.com/apache/airflow/pull/19758#discussion_r822326341
##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -412,25 +412,50 @@ paths:
- $ref: '#/components/parameters/PageOffset'
- $ref: '#/components/parameters/OrderBy'
- $ref: '#/components/parameters/FilterTags'
- - name: only_active
+ - $ref: '#/components/parameters/OnlyActive'
+ - name: dag_id_pattern
in: query
schema:
- type: boolean
- default: true
+ type: string
required: false
description: |
- Only return active DAGs.
+ If set, only return DAGs with dag_ids matching this pattern.
Review comment:
We should remove dag_id_pattern on /dags endpoint and make it a separate
PR then add tests for it. Currently, there's no test for it and it will be good
to make this change in a separate PR
##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -412,25 +412,50 @@ paths:
- $ref: '#/components/parameters/PageOffset'
- $ref: '#/components/parameters/OrderBy'
- $ref: '#/components/parameters/FilterTags'
- - name: only_active
+ - $ref: '#/components/parameters/OnlyActive'
+ - name: dag_id_pattern
in: query
schema:
- type: boolean
- default: true
+ type: string
required: false
description: |
- Only return active DAGs.
+ If set, only return DAGs with dag_ids matching this pattern.
+ responses:
+ '200':
+ description: Success.
+ content:
+ application/json:
+ schema:
+ $ref: '#/components/schemas/DAGCollection'
+ '401':
+ $ref: '#/components/responses/Unauthenticated'
- *New in version 2.1.1*
+ patch:
+ summary: Update DAGs
Review comment:
Add a description: field and also update that this is new in 2.3.0
##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -412,25 +412,50 @@ paths:
- $ref: '#/components/parameters/PageOffset'
- $ref: '#/components/parameters/OrderBy'
- $ref: '#/components/parameters/FilterTags'
- - name: only_active
+ - $ref: '#/components/parameters/OnlyActive'
+ - name: dag_id_pattern
in: query
schema:
- type: boolean
- default: true
+ type: string
required: false
description: |
- Only return active DAGs.
+ If set, only return DAGs with dag_ids matching this pattern.
+ responses:
+ '200':
+ description: Success.
+ content:
+ application/json:
+ schema:
+ $ref: '#/components/schemas/DAGCollection'
+ '401':
+ $ref: '#/components/responses/Unauthenticated'
- *New in version 2.1.1*
Review comment:
This shouldn't be removed or am I missing something? Looks like it
should be at 3814 or in a description field under `/dags`
##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -412,25 +412,50 @@ paths:
- $ref: '#/components/parameters/PageOffset'
- $ref: '#/components/parameters/OrderBy'
- $ref: '#/components/parameters/FilterTags'
- - name: only_active
+ - $ref: '#/components/parameters/OnlyActive'
+ - name: dag_id_pattern
in: query
schema:
- type: boolean
- default: true
+ type: string
required: false
description: |
- Only return active DAGs.
+ If set, only return DAGs with dag_ids matching this pattern.
+ responses:
+ '200':
+ description: Success.
+ content:
+ application/json:
+ schema:
+ $ref: '#/components/schemas/DAGCollection'
+ '401':
+ $ref: '#/components/responses/Unauthenticated'
- *New in version 2.1.1*
+ patch:
+ summary: Update DAGs
+ x-openapi-router-controller: airflow.api_connexion.endpoints.dag_endpoint
+ operationId: patch_dags
+ parameters:
+ - $ref: '#/components/parameters/PageLimit'
+ - $ref: '#/components/parameters/PageOffset'
+ - $ref: '#/components/parameters/FilterTags'
+ - $ref: '#/components/parameters/UpdateMask'
+ - $ref: '#/components/parameters/OnlyActive'
- name: dag_id_pattern
in: query
schema:
type: string
- required: false
+ required: true
description: |
If set, only return DAGs with dag_ids matching this pattern.
Review comment:
```suggestion
If set, only update DAGs with dag_ids matching this pattern.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
