jedcunningham commented on a change in pull request #22143:
URL: https://github.com/apache/airflow/pull/22143#discussion_r824145422
##########
File path: chart/templates/_helpers.yaml
##########
@@ -607,6 +607,43 @@ Create the name of the cleanup service account to use
{{- end }}
{{- end }}
+{{define "scheduler_liveness_check_command"}}
+
+ {{- if semverCompare ">=2.0.0" .Values.airflowVersion }}
+ - sh
+ - -c
+ - |
+ CONNECTION_CHECK_MAX_COUNT=0 exec /entrypoint bash -c \
+ "export AIRFLOW__LOGGING__LOGGING_LEVEL=ERROR && \
+ airflow jobs check --job-type SchedulerJob --hostname $(hostname)"
Review comment:
```suggestion
CONNECTION_CHECK_MAX_COUNT=0 AIRFLOW__LOGGING__LOGGING_LEVEL=ERROR \
exec /entrypoint bash -c \
"airflow jobs check --job-type SchedulerJob --hostname $(hostname)"
```
This is probably better...
Also, I don't think we need nested sh/bash, does this work?:
```suggestion
CONNECTION_CHECK_MAX_COUNT=0 AIRFLOW__LOGGING__LOGGING_LEVEL=ERROR \
exec /entrypoint airflow jobs check --job-type SchedulerJob --hostname
$(hostname)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
