ashb commented on a change in pull request #22184:
URL: https://github.com/apache/airflow/pull/22184#discussion_r825338095
##########
File path: airflow/dag_processing/processor.py
##########
@@ -412,20 +411,19 @@ def manage_slas(self, dag: DAG, session: Session = None)
-> None:
else:
while next_info.logical_date < ts:
next_info = dag.next_dagrun_info(next_info.data_interval,
restricted=False)
-
if next_info is None:
break
- if (ti.dag_id, ti.task_id, next_info.logical_date) in
recorded_slas_query:
+ if (ti.dag_id, ti.task_id, ti.run_id, ti.map_index) in
recorded_sla_misses:
Review comment:
Hmmm, SLAs are horribly broken in many ways right now, and I'd like us
to not get into the weeds here fixing that _now_.
Thinking what is the minimum we can do. Like I wonder if we could not touch
_anything_ here, and (for now/the 2.3 release) we forbid SLAs form being set on
mapped tasks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
