zachliu commented on pull request #22137:
URL: https://github.com/apache/airflow/pull/22137#issuecomment-1067060405
@potiuk now i have definitive proof that this works like 99% perfectly:
```
[2022-03-12, 07:20:05 EST] {{before.py:35}} INFO - Starting call to
'airflow.providers.amazon.aws.operators.ecs.EcsOperator._start_wait_check_task',
this is the 1st time calling it.
[2022-03-12, 07:20:06 EST] {{ecs.py:371}} INFO - ECS Task started: ...
[2022-03-12, 07:20:06 EST] {{ecs.py:375}} INFO - ECS task ID is:
a52de9c027c14052a9c93933a8dc0958
[2022-03-12, 07:20:06 EST] {{ecs.py:321}} INFO - Starting ECS Task Log
Fetcher
[2022-03-12, 07:20:21 EST] {{base_aws.py:100}} INFO - Retrieving region_name
from Connection.extra_config['region_name']
[2022-03-12, 07:23:37 EST] {{ecs.py:448}} INFO - ECS Task stopped, check
status: ...
[2022-03-12, 07:23:37 EST] {{before.py:35}} INFO - Starting call to
'airflow.providers.amazon.aws.operators.ecs.EcsOperator._start_wait_check_task',
this is the 1st time calling it.
[2022-03-12, 07:23:47 EST] {{before.py:35}} INFO - Starting call to
'airflow.providers.amazon.aws.operators.ecs.EcsOperator._start_wait_check_task',
this is the 2nd time calling it.
[2022-03-12, 07:23:47 EST] {{ecs.py:371}} INFO - ECS Task started: ...
```
with the 1% imperfection being the duplicate log entry...
it is because in the `base_aws.py` we used the same logger for both `before`
and `after`:
https://github.com/apache/airflow/blob/6fee5e0f983be3e1fdccd3e3c2879b0ace1d529c/airflow/providers/amazon/aws/hooks/base_aws.py#L592-L593
another simple PR coming right up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
