ferruzzi commented on a change in pull request #21863: URL: https://github.com/apache/airflow/pull/21863#discussion_r826433470
########## File path: airflow/providers/amazon/aws/hooks/quicksight.py ########## @@ -0,0 +1,141 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import time + +from botocore.exceptions import ClientError + +from airflow import AirflowException +from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook + + +class QuickSightHook(AwsBaseHook): + """ + Interact with Amazon QuickSight. + + Additional arguments (such as ``aws_conn_id``) may be specified and + are passed down to the underlying AwsBaseHook. + .. seealso:: + :class:`~airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook` + """ + + NON_TERMINAL_STATES = {"INITIALIZED", "QUEUED", "RUNNING"} + FAILED_STATES = {"FAILED"} + + def __init__(self, *args, **kwargs): + super().__init__(client_type="quicksight", *args, **kwargs) + + def create_ingestion( + self, + data_set_id: str, + ingestion_id: str, + aws_account_id: str, Review comment: It seems odd that all of their client calls for Quicksight take the account ID as a parameter. If you don't want to take it as an input, you get get it from [STS.get_caller_identity(): ]( https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sts.html#STS.Client.get_caller_identity) and I'd suggest fetching it once programmatically then storing it as a field in the QuicksightHook rather than passing it all over the place. This should do the trick inline: ``` import boto3 boto3.client('sts').get_caller_identity()['Account'] ``` But if you want to follow Airflow structure and add an STS hook it would look like this: ``` class StsHook(AwsBaseHook): def __init__(self) -> None: super().__init__(client_type='sts') def get_account_number(self) -> Dict: return self.conn.get_caller_identity()['Account'] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
