uranusjr commented on a change in pull request #22184:
URL: https://github.com/apache/airflow/pull/22184#discussion_r826682062
##########
File path: airflow/models/taskinstance.py
##########
@@ -425,6 +425,16 @@ class TaskInstance(Base, LoggingMixin):
dag_run = relationship("DagRun", back_populates="task_instances",
lazy='joined', innerjoin=True)
rendered_task_instance_fields = relationship("RenderedTaskInstanceFields",
lazy='noload', uselist=False)
+ sla_miss = relationship(
Review comment:
Looks good to me but I’d just spell ou `primaryjoin` literally; using
`join` seems like an overkiil.
```python
primaryjoin="""and_(
TaskInstance.dag_id == foreign(SlaMiss.dag_id),
TaskInstance.task_id == foreign(SlaMiss.task_id),
TaskInstance.run_id == foreign(SlaMiss.run_id),
TaskInstance.map_index == foreign(SlaMiss.map_index),
)"""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
