uranusjr commented on a change in pull request #22260:
URL: https://github.com/apache/airflow/pull/22260#discussion_r830454393
##########
File path: tests/core/test_core.py
##########
@@ -89,22 +89,25 @@ def test_task_fail_duration(self, dag_maker):
)
dag_maker.create_dagrun()
session = settings.Session()
- try:
- op1.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE,
ignore_ti_state=True)
- except Exception:
- pass
- try:
+ op1.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE,
ignore_ti_state=True)
+ with suppress(AirflowTaskTimeout):
op2.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE,
ignore_ti_state=True)
- except Exception:
- pass
op1_fails = (
session.query(TaskFail)
- .filter_by(task_id='pass_sleepy', dag_id=dag.dag_id,
execution_date=DEFAULT_DATE)
+ .filter(
+ TaskFail.task_id == 'pass_sleepy',
+ TaskFail.dag_id == dag.dag_id,
+ TaskInstance.execution_date == DEFAULT_DATE,
+ )
.all()
)
op2_fails = (
session.query(TaskFail)
- .filter_by(task_id='fail_sleepy', dag_id=dag.dag_id,
execution_date=DEFAULT_DATE)
+ .filter(
+ TaskFail.task_id == 'fail_sleepy',
+ TaskFail.dag_id == dag.dag_id,
+ TaskInstance.execution_date == DEFAULT_DATE,
+ )
Review comment:
```suggestion
.filter(
TaskFail.task_id == 'fail_sleepy',
TaskFail.dag_id == dag.dag_id,
DagRun.execution_date == DEFAULT_DATE,
)
```
Same for other calls above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
