eladkal commented on a change in pull request #22395:
URL: https://github.com/apache/airflow/pull/22395#discussion_r830921840
##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -2052,6 +2053,8 @@ class BigQueryInsertJobOperator(BaseOperator):
Service Account Token Creator IAM role to the directly preceding
identity, with first
account from the list granting this role to the originating account
(templated).
:param cancel_on_kill: Flag which indicates whether cancel the hook's job
or not, when on_kill is called
+ :param retry: Designation of what errors, if any, should be retried.
Review comment:
I appreciate that but note also that other functions in the hook has
this parameter already defined as retry and also with default of `DEFAULT_RETRY`
https://github.com/apache/airflow/blob/71c980a8ffb3563bf16d8a23a58de54c9e8cf556/airflow/providers/google/cloud/hooks/bigquery.py#L320
https://github.com/apache/airflow/blob/71c980a8ffb3563bf16d8a23a58de54c9e8cf556/airflow/providers/google/cloud/hooks/bigquery.py#L478
I would suggest to check how/if other operators utilize the retry in the
other functions it should help to make a decision what is the best approach
here. I don't feel strongly about any specific approach just want to make sure
that we are consistent (or if we want to change conventions that is also ok -
just require more work)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
