sagmansercan commented on a change in pull request #22389:
URL: https://github.com/apache/airflow/pull/22389#discussion_r831411667
##########
File path: airflow/configuration.py
##########
@@ -608,6 +609,43 @@ def getjson(self, section, key, fallback=_UNSET, **kwargs)
-> Union[dict, list,
except JSONDecodeError as e:
raise AirflowConfigException(f'Unable to parse [{section}] {key!r}
as valid json') from e
+ def gettimedelta(self, section, key, fallback=None, **kwargs) ->
Optional[datetime.timedelta]:
+ """
+ Gets the config value for the given section and key, and converts it
into datetime.timedelta object.
+ If the key is missing or set to a non-positive value, then it is
considered as `None`.
+
+ :param section: the section from the config
+ :param key: the key defined in the given section
+ :param fallback: fallback value when no config value is given,
defaults to None
+ :raises AirflowConfigException: raised because ValueError or
OverflowError
+ :return: datetime.timedelta(seconds=<config_value>) or None
+ """
+ val = self.get(section, key, fallback=fallback, **kwargs)
+
+ if val:
+ # the given value must be convertible to integer
+ try:
+ int_val = int(val)
+ except ValueError:
+ raise AirflowConfigException(
+ f'Failed to convert value to int. Please check "{key}" key
in "{section}" section. '
+ f'Current value: "{val}".'
+ )
+
+ # the given value must be positive. Otherwise fallback value is
returned.
+ if int_val <= 0:
+ return fallback
+
+ try:
+ return datetime.timedelta(seconds=int_val)
+ except OverflowError:
+ raise AirflowConfigException(
+ f'Failed to convert value to timedelta in `seconds`. '
+ f'Please check "{key}" key in "{section}" section. Current
value: "{val}".'
Review comment:
The error message is now included in the exception ✅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
