[ 
https://issues.apache.org/jira/browse/AIRFLOW-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852886#comment-16852886
 ] 

ASF GitHub Bot commented on AIRFLOW-4586:
-----------------------------------------

ramandumcs commented on pull request #5353: AIRFLOW-4586 There is no need to 
check explicitly for queued dependen…
URL: https://github.com/apache/airflow/pull/5353
 
 
   …cy as all dependencies can be checked as part of RUN_DEPS. Currently task 
gets stuck in queued state if QUEUE_DEPS are not met here
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Task getting stuck in Queued State
> ----------------------------------
>
>                 Key: AIRFLOW-4586
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4586
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 1.10.0
>            Reporter: raman
>            Priority: Major
>
> We are observing intermittently that Tasks get stuck in queued state and 
> never get executed by Airflow. On debugging it we found that one of the 
> queued dependency was not met due to which task did not move from queued to 
> running state. So task remained in queued state. (are_dependencies_met 
> function returned false for QUEUE_DEPS inside 
> _check_and_change_state_before_execution).
> By looking into scheduler code it seems that scheduler does not reschedule 
> the queued state tasks due to which task never got added to executor queue 
> again and remained stuck in queued state. There is a logic inside 
> _check_and_change_state_before_execution function to move the task from 
> queued to None state(which gets picked by scheduler for rescheduling) if 
> RUN_DEPS are not met but this logic seems to be missing for QUEUE_DEPS. It 
> seems that task should be moved to None state even if QUEUE_DEPS are not met.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to