potiuk commented on pull request #22492:
URL: https://github.com/apache/airflow/pull/22492#issuecomment-1076650709
cc: @Bowrna - this one results in a few changes to the part you do on the
prod image building #21956 . I've done some of them here, but some more changes
are needed to bring the changes also to the python PROD Build too:
* I removed "fix_group_permissions" part - from both the old Breeze and the
new one (so you do not need to do anything for that one). This is a good
example of "code is not an asset but liability" - by inlining the scripts I
could finally get rid of all the permission problems that various host
configuration could cause and rebuilding the image with cache will be much more
predictable, but also we could get rid of the "not-very-reliable" code that I
added to workaround that problem before (not very succesfully often) :). -
inlining the scripts to the image solves it completely
* There is a need to add few changes (you will see it there)
--build-arg DOCKERF_CONTEXT_FILES="docker-context-files" needs to be
added in "prod build" command
--cache:max should be added also in the CI image (because it is
multi-segment image now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
