Bowrna commented on a change in pull request #22502:
URL: https://github.com/apache/airflow/pull/22502#discussion_r834201201



##########
File path: airflow/providers/docker/hooks/docker.py
##########
@@ -55,6 +55,7 @@ def __init__(
         base_url: Optional[str] = None,
         version: Optional[str] = None,
         tls: Optional[str] = None,
+        timeout: int = 60,

Review comment:
       @eladkal yes I could import the default from the package, that way it's 
easy to maintain. One other option I thought is to keep it None by default and 
not pass it at all if it's None. So that it will pick the default one when we 
don't pass to APIClient




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to