potiuk opened a new pull request #22568: URL: https://github.com/apache/airflow/pull/22568
Change caching strategy for image builds. We used "registry" but we switch to "inline" which is better because we do not need to have separate "cache" tag for the image, caching metadata is stored in the image manifests, which means that for the build we can use the cache in the image itself when we build image locally. This also fixes '--link' layers the images if cache is not available. Previously we changed the ownership of the scripts and .local folder to be airflow user but this was not really needed and even harmful as those scripts could be modified by `airflow` user (even by mistake). This caused problems when the scripts were used from the cache, because when --link is used to copy the layers the user might not be created yet. It turns out that you shoud never have --link and --chown for the user that is created in previous steps. The scripts are now owned by root users and the ".local" layer that should be owned by the airflow user is now copied without --link flag. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
