ashb commented on a change in pull request #22123: URL: https://github.com/apache/airflow/pull/22123#discussion_r837064176
########## File path: airflow/www/static/js/tree/ResetRoot.jsx ########## @@ -0,0 +1,55 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import React from 'react'; +import { Button, Link } from '@chakra-ui/react'; + +import { getMetaValue } from '../utils'; + +const dagId = getMetaValue('dag_id'); +const numRuns = getMetaValue('num_runs'); +const urlRoot = getMetaValue('root'); +const baseDate = getMetaValue('base_date'); + +const ResetRoot = () => { + let rootLink; + if (urlRoot) { + const params = new URLSearchParams(); + if (numRuns) params.set('num_runs', numRuns); + if (baseDate) params.set('base_date', baseDate); + rootLink = `/dags/${dagId}/grid?${params.toString()}`; Review comment: We can't hard code the URL like this - airflow can be rooted/deployed to a location other than `/`. In other places we put the URL in a meta tag from the jinja templates for this purpose. ########## File path: airflow/www/static/js/tree/api/useClearTask.js ########## @@ -0,0 +1,77 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import axios from 'axios'; +import { useToast } from '@chakra-ui/react'; +import { useMutation, useQueryClient } from 'react-query'; +import { getMetaValue } from '../../utils'; +import { useAutoRefresh } from '../providers/autorefresh'; + +export default function useClearTask({ + dagId, runId, taskId, executionDate, +}) { + const queryClient = useQueryClient(); + const toast = useToast(); + const { startRefresh } = useAutoRefresh(); + + return useMutation( + ['clearTask', dagId, runId, taskId], + ({ + past, future, upstream, downstream, recursive, failed, confirmed, + }) => { + const csrfToken = getMetaValue('csrf_token'); + const params = new URLSearchParams({ + csrf_token: csrfToken, + dag_id: dagId, + dag_run_id: runId, + task_id: taskId, + confirmed, + execution_date: executionDate, + past, + future, + upstream, + downstream, + recursive, + only_failed: failed, + }).toString(); + + return axios.post('/clear', params, { Review comment: Same comment here about hard-coding URLs ########## File path: airflow/www/static/js/tree/api/index.js ########## @@ -0,0 +1,57 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import axios from 'axios'; +import camelcaseKeys from 'camelcase-keys'; + +import useDag from './useDag'; +import useTasks from './useTasks'; +import useClearRun from './useClearRun'; +import useQueueRun from './useQueueRun'; +import useMarkFailedRun from './useMarkFailedRun'; +import useMarkSuccessRun from './useMarkSuccessRun'; +import useRunTask from './useRunTask'; +import useClearTask from './useClearTask'; +import useMarkFailedTask from './useMarkFailedTask'; +import useMarkSuccessTask from './useMarkSuccessTask'; +import useExtraLinks from './useExtraLinks'; +import useConfirmMarkTask from './useConfirmMarkTask'; +import useTreeData from './useTreeData'; + +axios.interceptors.response.use( + (res) => (res.data ? camelcaseKeys(res.data, { deep: true }) : res), +); + +axios.defaults.headers.common.Accept = 'application/json'; + +export { + useDag, Review comment: Why the `use` prefix on all these functions/nodules? It looks slightly odd to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
