jedcunningham commented on a change in pull request #22573:
URL: https://github.com/apache/airflow/pull/22573#discussion_r837754616
##########
File path: setup.py
##########
@@ -1033,17 +1050,29 @@ def
replace_extra_requirement_with_provider_packages(extra: str, providers: List
['simple-salesforce>=1.0.0', 'tableauserverclient']
So transitively 'salesforce' extra has all the requirements it needs and
in case the provider
- changes it's dependencies, they will transitively change as well.
+ changes its dependencies, they will transitively change as well.
In the constraint mechanism we save both - provider versions and it's
dependencies
version, which means that installation using constraints is repeatable.
+ For K8s, Celery which are both "Core executors" and "Providers" we have to
Review comment:
```suggestion
For K8s and Celery which are both "Core executors" and "Providers" we
have to
```
##########
File path: setup.py
##########
@@ -1033,17 +1050,29 @@ def
replace_extra_requirement_with_provider_packages(extra: str, providers: List
['simple-salesforce>=1.0.0', 'tableauserverclient']
So transitively 'salesforce' extra has all the requirements it needs and
in case the provider
- changes it's dependencies, they will transitively change as well.
+ changes its dependencies, they will transitively change as well.
In the constraint mechanism we save both - provider versions and it's
dependencies
version, which means that installation using constraints is repeatable.
+ For K8s, Celery which are both "Core executors" and "Providers" we have to
+ add the base dependencies to the core as well - in order to mitigate
problems where
+ newer version of provider will have less strict limits. This should be
done for both
+ extras and their deprecated aliases. This is not a full protection
however, the way
+ extras work, this will not add "hard" limits for Airflow and the user who
does not use
+ constraints
Review comment:
```suggestion
constraints.
```
##########
File path: setup.py
##########
@@ -1033,17 +1050,29 @@ def
replace_extra_requirement_with_provider_packages(extra: str, providers: List
['simple-salesforce>=1.0.0', 'tableauserverclient']
So transitively 'salesforce' extra has all the requirements it needs and
in case the provider
- changes it's dependencies, they will transitively change as well.
+ changes its dependencies, they will transitively change as well.
In the constraint mechanism we save both - provider versions and it's
dependencies
version, which means that installation using constraints is repeatable.
+ For K8s, Celery which are both "Core executors" and "Providers" we have to
+ add the base dependencies to the core as well - in order to mitigate
problems where
Review comment:
```suggestion
add the base dependencies to core as well, in order to mitigate problems
where
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
