pingzh commented on a change in pull request #22389:
URL: https://github.com/apache/airflow/pull/22389#discussion_r838800949
##########
File path: airflow/configuration.py
##########
@@ -608,6 +609,48 @@ def getjson(self, section, key, fallback=_UNSET, **kwargs)
-> Union[dict, list,
except JSONDecodeError as e:
raise AirflowConfigException(f'Unable to parse [{section}] {key!r}
as valid json') from e
+ def gettimedelta(self, section, key, fallback=None, **kwargs) ->
Optional[datetime.timedelta]:
Review comment:
hi @sagmansercan i was thinking about the naming of this method,
`gettimedelta` vs `get_timedelta`.
`gettimedelta` conforms the current naming convention under `conf`, like
`getint`. However, there are two `t`s in the naming, making it harder to read.
but it is not a big deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
