ashb edited a comment on pull request #22123:
URL: https://github.com/apache/airflow/pull/22123#issuecomment-1084716869
Feedback. (some of these can be in follow up PRs.)
1. Dag name clickable but doesn't do anything
URL: `http://localhost:8080/dags/mapped_bash_notaskgroup/grid` (click
dag name from home page
It's a bit odd to have the dag id look and act like a link, but not do
anything
2. ~Clicking on the DagRun bar gives react error~
~Click where arrow is pointing~
Error in web console:
```
Warning: React.createElement: type is invalid -- expected a string (for
built-in components) or a class/function (for composite components) but got:
undefined. You likely forgot to export your component from the file it's
defined in, or you might have mixed up default and named imports.
Check the render method of `DagRun`.
DagRun@webpack-internal:///./static/js/tree/details/content/dagRun/index.jsx:48:16
```
Edit: was yarn/webpack issue. Rebuilding and it works now.
3. Lack of pushState means back button doesn't do what I expect (takes me
back to home page, not previous view.
4. For a mapped TI, "All Instances" doesn't filter to the current dag run,
It's _all_ instances of that task, This was unexpected to me. (The task
hadn't yet run, it was scheduled.)
5. Something made a GET request that included a csrf_token -- it's should
_not_ be sent for GET requests.
`[2022-03-31 16:02:07,660] 647276 MainProcess {{werkzeug
_internal.py:113}} INFO - 127.0.0.1 - - [31/Mar/2022 16:02:07] "GET
/dags/mapped_bash_notaskgroup/grid?root=&dag_id=mapped_bash_notaskgroup&_csrf_token=ImU5NzNhNTNjNmQ2NTE3N2U0MTYzMGQyODEwOTkxNDU3NzNiMThlMjIi.YkXBwg.RkGHB2tbVF1KVM7dzy3wkDKxjp0&base_date=1971-04-07+00%3A00%3A00%2B00%3A00&num_runs=365
HTTP/1.1" 200 -`
Oh, and that also includes a dag_id query parameter which it shouldn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
