Bowrna commented on a change in pull request #22660:
URL: https://github.com/apache/airflow/pull/22660#discussion_r840326564
##########
File path: dev/breeze/src/airflow_breeze/prod/prod_params.py
##########
@@ -47,10 +47,10 @@ class ProdParams:
install_docker_context_files: bool
disable_pypi_when_building: bool
disable_pip_cache: bool
- upgrade_to_newer_dependencies: str
- skip_installing_airflow_providers_from_sources: bool
- cleanup_docker_context_files: bool
- prepare_buildx_cache: bool
+ upgrade_to_newer_dependencies: str = "false"
+ skip_installing_airflow_providers_from_sources: bool = False
Review comment:
@potiuk `skip_installing_airflow_providers_from_sources`,
`cleanup_docker_context_files`, ` prepare_buildx_cache`. Do we have to keep
these flags `False` by default? Because when user doesn't pass them it will be
False and that's why i didn't keep it default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
