potiuk opened a new pull request #22687: URL: https://github.com/apache/airflow/pull/22687
This PR re-arranges tags int GitHub actions to be more explicit in the pull/build/push steps on which tag of the image is currently pulled/pushed/built. Previously the actual configuration of those steps was determined by combining "top", "job" and "step" variables, but that gave little insight on what combinations of evn variables was used in the step eventually. After this change, in all the pull/push/build steps you can see what environment is used for that build. Also, since we often build and push and then pull the same image in the same workflow, the PUSH tag was sometimes used in PULL variable as input. We change it now by introducing single `IMAGE_TAG_FOR_THE_BUILD` which will be used as PUSH and PULL tag as needed. This one also fixes failure of PROD cache builds which did not pull the right CI image. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
