potiuk commented on a change in pull request #22685:
URL: https://github.com/apache/airflow/pull/22685#discussion_r841108008



##########
File path: airflow/dag_processing/processor.py
##########
@@ -231,6 +232,10 @@ def _kill_process(self) -> None:
         if self._process.is_alive() and self._process.pid:
             self.log.warning("Killing DAGFileProcessorProcess (PID=%d)", 
self._process.pid)
             os.kill(self._process.pid, signal.SIGKILL)
+
+            # Reap the spawned zombie

Review comment:
       Small suggestion - to capture the discussion above. This is basically 
the type of comment for the "future me". I (and we all) will likely forget why 
this is done this way and we might atempt to fix the active waiting :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to