[ 
https://issues.apache.org/jira/browse/AIRFLOW-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854572#comment-16854572
 ] 

ASF GitHub Bot commented on AIRFLOW-929:
----------------------------------------

arybin93 commented on pull request #5365: [AIRFLOW-929] - Fix log url via 
relative path
URL: https://github.com/apache/airflow/pull/5365
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   - [x] [AIRFLOW-929](https://issues.apache.org/jira/browse/AIRFLOW-929) 
   
   ### Description
   
   - [x] Add relative path for `log_url` and for `mark_success_url` property 
for `TaskInstance`
     Fixed tests and add absolute path for `email_alert`
   
   ### Tests
   
   - [x] My PR follow existing unit tests
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] Changes in docs don't required
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> When viewing the Browse -> Task Instances list, the log link on far right 
> links to localhost
> --------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-929
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-929
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Jason Kromm
>            Priority: Minor
>         Attachments: 1.10.3.PNG
>
>
> When viewing the Browse -> Task Instances list, the log link on far right 
> links to localhost:8080



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to