jedcunningham commented on code in PR #22092:
URL: https://github.com/apache/airflow/pull/22092#discussion_r842091082
##########
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py:
##########
@@ -211,7 +211,7 @@ def test_find_pod_labels(self):
do_xcom_push=False,
)
self.run_pod(k)
- self.client_mock.return_value.list_namespaced_pod.assert_called_once()
+ self.client_mock.return_value.list_namespaced_pod.assert_called()
Review Comment:
Not sure if this provides much value any longer? Should we check the call
count?
##########
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py:
##########
@@ -272,6 +277,32 @@ def test_pod_delete_even_on_launcher_error(self,
delete_pod_mock):
k.execute(context=context)
assert delete_pod_mock.called
+
@mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.delete_pod")
+ @mock.patch(
+ "airflow.providers.cncf.kubernetes.operators.kubernetes_pod"
".KubernetesPodOperator.find_pod"
Review Comment:
```suggestion
"airflow.providers.cncf.kubernetes.operators.kubernetes_pod.KubernetesPodOperator.find_pod"
```
##########
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py:
##########
@@ -785,7 +820,12 @@ def test_previous_pods_ignored_for_reattached(self):
"airflow.providers.cncf.kubernetes.operators.kubernetes_pod"
".KubernetesPodOperator.patch_already_checked"
)
- def test_mark_created_pod_if_not_deleted(self, mock_patch_already_checked,
mock_delete_pod):
+ @mock.patch(
+ "airflow.providers.cncf.kubernetes.operators.kubernetes_pod"
".KubernetesPodOperator.find_pod"
Review Comment:
```suggestion
"airflow.providers.cncf.kubernetes.operators.kubernetes_pod.KubernetesPodOperator.find_pod"
```
##########
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py:
##########
@@ -831,7 +878,12 @@ def test_mark_created_pod_if_not_deleted_during_exception(
"airflow.providers.cncf.kubernetes.operators."
"kubernetes_pod.KubernetesPodOperator.patch_already_checked"
)
- def test_mark_reattached_pod_if_not_deleted(self,
mock_patch_already_checked, mock_delete_pod):
+ @mock.patch(
+ "airflow.providers.cncf.kubernetes.operators."
"kubernetes_pod.KubernetesPodOperator.find_pod"
Review Comment:
```suggestion
"airflow.providers.cncf.kubernetes.operators.kubernetes_pod.KubernetesPodOperator.find_pod"
```
##########
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py:
##########
@@ -808,8 +850,11 @@ def test_mark_created_pod_if_not_deleted(self,
mock_patch_already_checked, mock_
"airflow.providers.cncf.kubernetes.operators.kubernetes_pod"
".KubernetesPodOperator.patch_already_checked"
)
+ @mock.patch(
+ "airflow.providers.cncf.kubernetes.operators."
"kubernetes_pod.KubernetesPodOperator.find_pod"
Review Comment:
```suggestion
"airflow.providers.cncf.kubernetes.operators.kubernetes_pod.KubernetesPodOperator.find_pod"
```
##########
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py:
##########
@@ -534,7 +565,10 @@ def test_pod_template_file_kwargs_override(self,
randomize_name, pod_template_fi
@mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.fetch_container_logs")
@mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.await_container_completion")
- def test_describes_pod_on_failure(self, await_container_mock,
fetch_container_mock):
+ @mock.patch(
+ "airflow.providers.cncf.kubernetes.operators.kubernetes_pod"
".KubernetesPodOperator.find_pod"
Review Comment:
```suggestion
"airflow.providers.cncf.kubernetes.operators.kubernetes_pod.KubernetesPodOperator.find_pod"
```
##########
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py:
##########
@@ -252,7 +252,12 @@ def test_image_pull_policy_correctly_set(self):
assert pod.spec.containers[0].image_pull_policy == "Always"
@mock.patch("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.delete_pod")
- def test_pod_delete_even_on_launcher_error(self, delete_pod_mock):
+ @mock.patch(
+ "airflow.providers.cncf.kubernetes.operators.kubernetes_pod"
".KubernetesPodOperator.find_pod"
Review Comment:
```suggestion
"airflow.providers.cncf.kubernetes.operators.kubernetes_pod.KubernetesPodOperator.find_pod"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
