potiuk commented on a change in pull request #4937: [AIRFLOW-4116] Multi-staging includes CI image [Step 2/3] URL: https://github.com/apache/airflow/pull/4937#discussion_r289838805
########## File path: Dockerfile-context ########## @@ -0,0 +1,20 @@ +# Review comment: I already tried it before. We can't use it because .dockerignore is quite different from .gitignore. Also in our case we use the different (recommended) pattern for dockerignore: exclude all + include only what's needed. This is much better for docker context stability. And simply having a separate simple docker like that one is a super easy way to see which files are added to context (then we can change the +g/-g flags for only those files - for docker cache invalidation purpose). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
