ashb commented on code in PR #21877:
URL: https://github.com/apache/airflow/pull/21877#discussion_r842606382
##########
airflow/jobs/scheduler_job.py:
##########
@@ -779,6 +779,22 @@ def _execute(self) -> None:
self.log.exception("Exception when executing
DagFileProcessorAgent.end")
self.log.info("Exited execute loop")
+ def _update_dag_run_state_for_paused_dags(self):
Review Comment:
I'm not too happy about this change -- the point of having this in
LocalTaskJob is so that the state of a dag run updates quickly after the task
finishes.
By moving it to the scheduler we've lost that.
Instead of moving this to the scheduler, could we move it "down" in to the
raw task process instead? That or I wonder if there is some way with AIP-44 to
add a callback from the LTJ if needed.
Final option: _If_ there are no callbacks we can still safely do this here,
so maybe we only need to do this in the scheduler in case of callbacks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
