ashb commented on a change in pull request #5349: [AIRFLOW-4591] Make
default_pool a real pool
URL: https://github.com/apache/airflow/pull/5349#discussion_r289872024
##########
File path: tests/www/api/experimental/test_endpoints.py
##########
@@ -291,14 +292,10 @@ class TestPoolApiExperimental(TestBase):
@classmethod
def setUpClass(cls):
super(TestPoolApiExperimental, cls).setUpClass()
- session = Session()
- session.query(Pool).delete()
- session.commit()
- session.close()
def setUp(self):
super().setUp()
-
+ clear_db_pools(create_default_pool=False)
Review comment:
I think it would be better to update the tests here to expect the default
pool to exist - and it shouldn't be possible to Airflow to get into a state
where the default_pool doesn't exist, so we might end up testing an
"impossible" case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
