ashb commented on code in PR #22832:
URL: https://github.com/apache/airflow/pull/22832#discussion_r845188533


##########
airflow/serialization/serialized_objects.py:
##########
@@ -629,7 +629,7 @@ def _serialize_node(cls, op: Union[BaseOperator, 
MappedOperator], include_deps:
         serialize_op['_task_module'] = getattr(op, "_task_module", 
type(op).__module__)
 
         # Used to determine if an Operator is inherited from DummyOperator
-        serialize_op['_is_dummy'] = op.inherits_from_dummy_operator
+        serialize_op['_is_empty'] = op.inherits_from_empty_operator

Review Comment:
   You should make a change in the deserialize code path so that if it sees 
`_is_dummy` it renames it to `_is_empty` -- although the DAG will get 
re-serialized eventually it's much nicer for bigger deployments if we can just 
seamless load the older serialization format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to