uranusjr commented on code in PR #22701:
URL: https://github.com/apache/airflow/pull/22701#discussion_r845868941
##########
tests/conftest.py:
##########
@@ -500,11 +500,12 @@ def create_dagrun(self, **kwargs):
dag = self.dag
kwargs = {
- "state": State.RUNNING,
"start_date": self.start_date,
"session": self.session,
**kwargs,
}
+ if "state" not in kwargs:
+ kwargs["state"] = State.RUNNING
Review Comment:
This should not be needed, the dict unpacking syntax already guarantees
`"state"` in `**kwargs` takes precedence over the one above it.
##########
tests/conftest.py:
##########
@@ -500,11 +500,12 @@ def create_dagrun(self, **kwargs):
dag = self.dag
kwargs = {
- "state": State.RUNNING,
"start_date": self.start_date,
"session": self.session,
**kwargs,
}
+ if "state" not in kwargs:
+ kwargs["state"] = State.RUNNING
Review Comment:
This should not be needed, the dict unpacking syntax already guarantees
`"state"` in `**kwargs` takes precedence over the one above it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
