[GitHub] [airflow] bbovenzi opened a new pull request, #22866: Fix Grid view font sizing

Fri, 08 Apr 2022 11:41:11 -0700 


bbovenzi opened a new pull request, #22866:
URL: https://github.com/apache/airflow/pull/22866

   Too many font sizes in Grid view were being set to `10px` from how we define 
`html { }`. Across the rest of the UI, this is overwritten by the style in 
`body { }`, but not in the shadow root we had to create for the react sections. 
After resetting a default size, this enabled us to clean up a lot of manual 
styling. 
   
   Also included: Cleaned up the Details header panel to remove the need of 
`color="black"` which was inconsistent with the rest of our colors.
   
   Before:
   <img width="1193" alt="Screen Shot 2022-04-08 at 2 35 56 PM" 
src="https://user-images.githubusercontent.com/4600967/162501919-61149ae7-bf19-4b52-b37a-22dd0c07a550.png";>
   
   After:
   <img width="1177" alt="Screen Shot 2022-04-08 at 2 35 24 PM" 
src="https://user-images.githubusercontent.com/4600967/162501974-7552940f-4876-4d95-8686-4972f62c2fec.png";>
   
   Before:
   <img width="1195" alt="Screen Shot 2022-04-08 at 2 36 10 PM" 
src="https://user-images.githubusercontent.com/4600967/162502018-5c419f89-852d-47af-9e23-00199895e7cf.png";>
   
   After:
   <img width="1181" alt="Screen Shot 2022-04-08 at 2 35 00 PM" 
src="https://user-images.githubusercontent.com/4600967/162502032-d7cd5a37-b414-4bff-9c9c-1cc6102a6de4.png";>
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to